First of all, since then-
Positive: Shang Yang's political reform reformed Qin from political, economic and cultural aspects, which played a direct role in the strength of Qin. Therefore, Shang Yang's political reform promoted the unification of China.
On the contrary, Shang Yang's political reform emphasized punishment, and the political framework he established aggravated the oppression of ordinary people.
Secondly, for future generations-
Positive: Because of the demise of tyranny in the Qin Dynasty, the later dynasties took a warning, adopted a more moderate rule over the people, and implemented a benevolent policy in a certain sense.
On the contrary, respecting Wang Siwei's thought has had a rather adverse impact on the development of post-China's democratic thought.
Finally, for today's society-
Positive: It has important reference significance for today's legal system and may be an interpretation of the rule of law in the East.